mistercrunch commented on code in PR #34156:
URL: https://github.com/apache/superset/pull/34156#discussion_r2208235138
##########
superset/db_engine_specs/snowflake.py:
##########
@@ -394,9 +394,11 @@ def update_params_from_encrypted_extra(
else:
with open(auth_params["privatekey_path"], "rb") as key_temp:
key = key_temp.read()
+ privatekey_pass = auth_params.get("privatekey_pass", None)
+ password = privatekey_pass.encode() if privatekey_pass is not None
else None
Review Comment:
My intuition looking at this if that we may be able to put this whole block
(from 398 to 409 inclusively) behind an if statement (if privatekey_pass:
{...}), but it could be that snowflake expects the
`connect_args["private_key"]` block with an empty password (?) Might be worth
trying whether this work, if it does it makes the code more clear ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
