LevisNgigi opened a new pull request, #34175: URL: https://github.com/apache/superset/pull/34175
### SUMMARY Related to [PR](https://github.com/apache/superset/pull/33126). Fixes a bug in the Table chart where percentage metrics (e.g., %count) did not appear or behave correctly in the Customize Columns section. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS 1) Go to Chart > Table and create a chart using a COUNT(*) or similar metric. 2) Add this metric to the Percentage Metrics section. 3)Run the chart,confirm that %count is visible in the result table. 4)Go to the Customize Columns section. You should now: a)See Main %count listed and the child columns. b)Be able to rename it (e.g., "Conversion Rate") c)Hide child columns, and verify they disappear from the table d)Also verify that comparison columns for %count are generated properly when time comparison is enabled and regular metrics like COUNT(*) are preserved and configurable ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
