nathanjrobertson commented on code in PR #33889:
URL: https://github.com/apache/superset/pull/33889#discussion_r2205978025
##########
helm/superset/Chart.yaml:
##########
@@ -29,7 +29,7 @@ maintainers:
- name: craig-rueda
email: [email protected]
url: https://github.com/craig-rueda
-version: 0.14.2
Review Comment:
I'd put a small comment in `values.yaml` as well. The penalty for somebody
inadvertently changing the version number and not adhering to the convention in
an environment where automation deploys updated versions (eg. CD in Kubernetes
environments) is high. Something like:
```
# For version X.Y.Z, X=0, Y is incremented for Superset version upgrades and
breaking changes in the chart, Z for patch releases and other non-breaking
changes. See <<link_to_docs>> for details.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
