gabotorresruiz commented on code in PR #34144:
URL: https://github.com/apache/superset/pull/34144#discussion_r2205550596
##########
superset-frontend/packages/superset-ui-core/src/theme/Theme.tsx:
##########
@@ -160,7 +164,7 @@ export class Theme {
* Dark mode should be specified via the algorithm property in the config
*/
setConfig(config: AnyThemeConfig): void {
- const antdConfig = normalizeThemeConfig(config);
+ const antdConfig: ThemeConfig = normalizeThemeConfig(config);
Review Comment:
I think it makes sense
##########
superset-frontend/packages/superset-ui-core/src/theme/Theme.tsx:
##########
@@ -169,7 +173,7 @@ export class Theme {
};
// First phase: Let Ant Design compute the tokens
- const tokens = Theme.getFilteredAntdTheme(antdConfig);
+ const tokens: SharedAntdTokens = Theme.getFilteredAntdTheme(antdConfig);
Review Comment:
Yep, I think it makes sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
