betodealmeida commented on code in PR #34139:
URL: https://github.com/apache/superset/pull/34139#discussion_r2200943974
##########
superset/extensions/pylint.py:
##########
@@ -85,18 +85,18 @@ class SQLParsingLibraryImportChecker(BaseChecker):
}
def _is_disallowed(self, file_path: Path, root_mod: str) -> bool:
- # True if sqlglot is imported outside superset/sql,
- # or if any forbidden library is imported anywhere
+ # Never allow sqlparse/sqloxide
+ if root_mod in {"sqlparse", "sqloxide"}:
+ return True
+
+ # Allow sqlglot inside superset/sql and in the config
allowed = {
- "**/supersql/sql/**/*.py",
- "**/supersql/sql/*.py",
Review Comment:
<img width="418" height="200" alt="image"
src="https://github.com/user-attachments/assets/883b7b78-4540-4915-9121-bd267ddd3d58";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
