rusackas commented on PR #33974: URL: https://github.com/apache/superset/pull/33974#issuecomment-3056572139
Claude likes this diff: Looking at these Japanese translation updates, they generally appear to be improvements in consistency and accuracy. Here are the key patterns I notice: Positive Changes: Terminology Consistency: "グラフ" (graph) → "チャート" (chart) - Better consistency with modern UI terminology "電子メールレポートがアクティブです" → "電子メールレポートが有効です" - More natural Japanese Translation Quality Improvements: "1ヶ月前" instead of just "月" for "1 month ago" - More precise "3次元" instead of "3日" for "3D" - Correct translation "10/90 パーセンタイル" with proper numbers instead of "9/91" Removing "fuzzy" Markers: Many translations had their #, fuzzy markers removed, indicating they've been reviewed and finalized. Better Formality: Adding "。" (periods) to error messages for proper sentence structure More consistent use of polite forms Potential Concerns: Question Mark Changes: "?" → "？" (full-width question mark) - This is actually correct for Japanese typography Some entries show blank translations: msgid "Email is required" msgstr "" This should probably have a Japanese translation. Technical terms: Some technical terms like "catalog", "schema" are kept in katakana, which is appropriate. Overall, these changes represent a positive update that improves consistency, accuracy, and naturalness of the Japanese translations. The systematic replacement of "グラフ" with "チャート" and other terminology standardizations show this was a well-planned localization improvement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
