mistercrunch commented on PR #34116: URL: https://github.com/apache/superset/pull/34116#issuecomment-3054492702
NOTE: ran into some nonsense around the `SequentialSchemeRegistrySingleton` where it makes it a bit tricky to do something dynamic based on `themeObject.isThemeDark()` since all the schemes are registered once in module scope. Would need to go a bit deeper. Seems the way color scalers are defined, they need the `extent()` of the data (min/max values) to get defined. Maybe that SequentialSchemeRegistrySingleton could be made theme-darkness-aware. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
