EnxDev opened a new pull request, #34112:
URL: https://github.com/apache/superset/pull/34112

   <!---
   Please write the PR title following the conventions at 
https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   This PR addresses a bug where the Connect button remains disabled when 
attempting to connect a database using the SQLAlchemy URI flow in the 
DatabaseModal.
   
   **Problem** #34110
   When selecting "Connect this database with a SQLAlchemy URI string instead", 
entering a valid URI does not enable the Connect button.
   
   This was likely introduced in #33826, which added stricter validation that 
does not currently account for the URI-based flow.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   1. Go to Data > Connect Database
   2. Choose any database (e.g., PostgreSQL)
   3. Select "Connect this database with a SQLAlchemy URI string instead"
   4. Enter a valid URI and test the connection
   5. After a successful test, the Connect button should now be enabled
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to