sadpandajoe commented on PR #34057: URL: https://github.com/apache/superset/pull/34057#issuecomment-3046842140
> Makes sense to speed up the pipeline, my intention with making those e2e were to check if fab views or frontend is loaded for login page and regression of that is highly unlikely. I can see that, but if the fields for logging in is broken the assumption there is that all tests would be broken since we wouldn't be able to log in. But just in case if things are broken, it'd be easier to catch in the component as people may just want to skip the tests instead of investigating. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
