mistercrunch commented on code in PR #34042:
URL: https://github.com/apache/superset/pull/34042#discussion_r2190870622
##########
superset-frontend/packages/superset-ui-core/src/theme/Theme.tsx:
##########
@@ -22,12 +22,20 @@ import React from 'react';
import { theme as antdThemeImport, ConfigProvider } from 'antd';
import tinycolor from 'tinycolor2';
+// @fontsource/* v5.1+ doesn't play nice with eslint-import plugin v2.31+
+/* eslint-disable import/extensions */
Review Comment:
Not related to this PR directly, but now I'm wondering if we use `200`
anywhere in the codebase.
Sees we use only these now ->
https://github.com/apache/superset/blob/master/superset-frontend/packages/superset-ui-core/src/theme/Theme.tsx#L90-L92
Found a few hard-coded values that don't match what we import here too.
Might be a good thing to clean this up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
