mistercrunch commented on code in PR #33962:
URL: https://github.com/apache/superset/pull/33962#discussion_r2173339950
##########
superset-frontend/.eslintrc.js:
##########
@@ -156,7 +161,7 @@ module.exports = {
'@typescript-eslint/no-non-null-assertion': 0, // disabled temporarily
'@typescript-eslint/explicit-function-return-type': 0,
'@typescript-eslint/explicit-module-boundary-types': 0, // re-enable
up for discussion
- '@typescript-eslint/prefer-optional-chain': 2,
+ '@typescript-eslint/no-unused-vars': 'warn', // downgrade to Warning
severity for Jest v30 upgrade
Review Comment:
Personally I prefer either extremes (fully enforce or fully skip, no warn).
Could fix in a future PR though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
