LisaHusband commented on code in PR #34016:
URL: https://github.com/apache/superset/pull/34016#discussion_r2178308083
##########
superset-frontend/plugins/plugin-chart-handlebars/src/plugin/controlPanel.tsx:
##########
@@ -38,10 +38,7 @@ import {
orderByControlSetItem,
orderDescendingControlSetItem,
} from './controls/orderBy';
-import {
- serverPageLengthControlSetItem,
- serverPaginationControlSetRow,
-} from './controls/pagination';
+import { serverPageLengthControlSetItem } from './controls/pagination';
Review Comment:
Thank you for the feedback!
I’ll keep working on this PR and update it accordingly.By the way, the
previous PR was automatically closed because both the main branch and my branch
had changes that were not merged yet. Regarding the removal of the API
implementation, I wonder if this API might still be needed or implemented by
someone else in the future. So for now, should we keep its implementation
temporarily?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
