Re: [PR] fix(Table): Override merge extra_form_data in props [superset]

Tue, 01 Jul 2025 08:07:11 -0700 


korbit-ai[bot] commented on code in PR #34014:
URL: https://github.com/apache/superset/pull/34014#discussion_r2177855258


##########
superset-frontend/plugins/plugin-chart-table/src/transformProps.ts:
##########
@@ -471,6 +472,11 @@ const transformProps = (
     emitCrossFilters,
   } = chartProps;
 
+  const formData = {
+    ...originalFormData,
+    ...originalFormData.extra_form_data,
+  } as TableChartFormData;

Review Comment:
   ### Shallow Merge of Configuration Objects <sub>![category 
Functionality](https://img.shields.io/badge/Functionality-0284c7)</sub>
   
   <details>
     <summary>Tell me more</summary>
   
   ###### What is the issue?
   The code merges extra_form_data at the root level, which means nested 
properties in extra_form_data will not be properly merged with their 
counterparts in originalFormData.
   
   
   ###### Why this matters
   If extra_form_data contains nested objects, they will completely override 
the corresponding objects in originalFormData instead of being deeply merged. 
This can lead to loss of configuration data.
   
   ###### Suggested change ∙ *Feature Preview*
   Use a deep merge function to properly combine the objects:
   ```typescript
   import { merge } from 'lodash';
   
   const formData = merge({}, originalFormData, 
originalFormData.extra_form_data) as TableChartFormData;
   ```
   
   
   ###### Provide feedback to improve future suggestions
   [![Nice 
Catch](https://img.shields.io/badge/👍%20Nice%20Catch-71BC78)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/8ca148bd-1e1c-4318-a8db-f0c30a4a9ec3/upvote)
 
[![Incorrect](https://img.shields.io/badge/👎%20Incorrect-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/8ca148bd-1e1c-4318-a8db-f0c30a4a9ec3?what_not_true=true)
  [![Not in 
Scope](https://img.shields.io/badge/👎%20Out%20of%20PR%20scope-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/8ca148bd-1e1c-4318-a8db-f0c30a4a9ec3?what_out_of_scope=true)
 [![Not in coding 
standard](https://img.shields.io/badge/👎%20Not%20in%20our%20standards-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/8ca148bd-1e1c-4318-a8db-f0c30a4a9ec3?what_not_in_standard=true)
 
[![Other](https://img.shields.io/badge/👎%20Other-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/8ca148bd-1e1c-4318-a8db-f0c30a4a9ec3)
   </details>
   
   <sub>
   
   💬 Looking for more details? Reply to this comment to chat with Korbit.
   </sub>
   
   <!--- korbi internal id:3db57a5b-762c-472e-acd2-bdfe3c08eeaa -->
   
   
   [](3db57a5b-762c-472e-acd2-bdfe3c08eeaa)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to