betodealmeida commented on PR #33955: URL: https://github.com/apache/superset/pull/33955#issuecomment-3016104694
> LGTM, trying to understand what happened here and whether we should expect more funk from the large merge. I'm the one on the `git blame` on `master` because of the "squash and merge" strategy, but I pulled the `git blame` from `template_less` and see this: > > ``` > b8354785147 (Mehmet Salih Yavuz 2025-04-08 15:14:15 +0300 356) > ``` > > Tagging Memo to see if he has a take on how this slip in. Guessing intricate merge conflict... Ah, it's because it generates `<div id="1"/>`, but an ID can't be a number. We need a better way of passing the DB ID. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
