nathanjrobertson commented on PR #33837: URL: https://github.com/apache/superset/pull/33837#issuecomment-3006580804
> IMO, the Helm attribute can be named something like `supersetNode.connections.postgresql.db_conn_params` as this is a bit tool-specific and I think we can reserve the generic term for other future uses. My 2cent. Connection parameters actually aren't proprietary to PostgreSQL. [MySQL and MariaDB use them as well](https://docs.sqlalchemy.org/en/20/dialects/mysql.html#supported-versions-and-features), as does [the Oracle driver](https://docs.sqlalchemy.org/en/20/dialects/oracle.html#dialect-oracle-oracledb-connect), [Microsoft SQL Server](https://docs.sqlalchemy.org/en/20/dialects/mssql.html#temporary-table-resource-reset-for-connection-pooling), even [SQLite](https://docs.sqlalchemy.org/en/20/dialects/sqlite.html#uri-connections) has them. Example for MySQL: ``` engine = create_engine( "mysql+pymysql://user:pass@some_mariadb/dbname?charset=utf8mb4" ) ``` The only thing is that makes this PR PostgreSQL specific is that the pre-existing template variable is already hardcoded to be PostgreSQL specific: https://github.com/apache/superset/blob/f802474b07bc7a2765e57fcd6612d2b4454f5c62/helm/superset/templates/_helpers.tpl#L99 The URL scheme in the chart template is hardcoded to `postgresql+psycopg2://`, meaning the chart currently is hardcoded to be PostgreSQL. Removing the PostgreSQL hardcoding (adding support for, and testing, other databases) is something for a different PR. The purpose of this PR is to add parameter support, and when the hardcoding is removed, this new variable would then apply to all databases supported by SQLAlchemy. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
