LisaHusband commented on PR #33857: URL: https://github.com/apache/superset/pull/33857#issuecomment-3002286733
> Would love to see this merged if it closes #33828 > > Looks like a pre-commit issue is failing CI. > > Superset uses Git pre-commit hooks courtesy of [pre-commit](https://pre-commit.com/). To install run the following: > > ``` > pip3 install -r requirements/development.txt > pre-commit install > ``` > > A series of checks will now run when you make a git commit. > > Alternatively it is possible to run pre-commit by running pre-commit manually: > > ``` > pre-commit run --all-files > ``` Thanks for the reminder 🙏. I've run pre-commit run --all-files and committed the fix for the trailing-whitespace hook issue (in superset/datasets/api.py). The file has been updated and pushed — the CI should pass now ✅. Also, pre-commit is now installed locally, and I'll make sure to follow the project's formatting conventions going forward. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
