mistercrunch commented on PR #33603: URL: https://github.com/apache/superset/pull/33603#issuecomment-2997869539
For context Theming + dark mode just landed in `master`, and we may have to think how we'll support visualization theming to align with this across the board. Seems most core visualization are now able to adapt nicely using grayscale, but for something like those deck.gl visualization, we may want to have the chart define options like "Map Style for Light Mode" and another "Map Style for Dark Mode", where the person saving the chart would have the option to specify both. It's not a requirement to sort this out prior to merging this PR, but would be nice to eventually have that option. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
