dosubot[bot] commented on issue #33862: URL: https://github.com/apache/superset/issues/33862#issuecomment-2996096228
<!-- Answer --> Your proposed change—setting class_permission_name = "Security" in both superset/views/roles.py and superset/views/users_list.py—is a safe and effective fix for the MySQL case-sensitivity issue. This approach aligns with how other menus (like SQLLab) are handled and ensures consistent behavior across all supported databases. There are no internal references to the lowercase "security" string, so this change won’t break existing code or configs, and it works fine on PostgreSQL as well. The only minor side effect is that old installs may have orphaned lowercase permissions, which are harmless. There are no existing pull requests for this fix, but similar issues have been discussed for other menus (like SQLLab), and the consensus is that aligning permission names with the menu label is the right approach for cross-database compatibility ([example](https://github.com/apache/superset/issues/31395)). If you submit a PR with this change, it should be straightforward to review and merge, as it improves out-of-the-box experience for MySQL and avoids manual DB tweaks. You might want to mention in the PR description that this resolves the regression described in [this thread](https://github.com/apache/superset/issues/33672) and cite the SQLLab precedent. Let me know if you want any help drafting the PR description or with anything else! <!-- Dosu Comment Footer --> *To reply, just mention [@dosu](https://go.dosu.dev/dosubot).* --- <sup>How did I do? [Good](https://app.dosu.dev/response-feedback/f730f5a6-f8df-403c-9c33-f508a989ce3d?feedback_type=great_response) | [Irrelevant](https://app.dosu.dev/response-feedback/f730f5a6-f8df-403c-9c33-f508a989ce3d?feedback_type=irrelevant_answer) | [Incorrect](https://app.dosu.dev/response-feedback/f730f5a6-f8df-403c-9c33-f508a989ce3d?feedback_type=incorrect_sources) | [Verbose](https://app.dosu.dev/response-feedback/f730f5a6-f8df-403c-9c33-f508a989ce3d?feedback_type=too_verbose) | [Hallucination](https://app.dosu.dev/response-feedback/f730f5a6-f8df-403c-9c33-f508a989ce3d?feedback_type=hallucination) | [Report 🐛](https://app.dosu.dev/response-feedback/f730f5a6-f8df-403c-9c33-f508a989ce3d?feedback_type=bug_report) | [Other](https://app.dosu.dev/response-feedback/f730f5a6-f8df-403c-9c33-f508a989ce3d?feedback_type=other)</sup> [](https://go.dosu.dev/discord-bot) [! [Share on X](https://img.shields.io/badge/X-share-black)](https://twitter.com/intent/tweet?text=%40dosu_ai%20helped%20me%20solve%20this%20issue!&url=https%3A//github.com/apache/superset/issues/33862) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
