Re: [PR] Update Docker setup [superset]

Sun, 22 Jun 2025 22:44:59 -0700 


korbit-ai[bot] commented on code in PR #33860:
URL: https://github.com/apache/superset/pull/33860#discussion_r2160760932


##########
superset/config.py:
##########
@@ -109,7 +109,7 @@
 #     "type": "image/png"
 #     "rel": "icon"
 # },
-FAVICONS = [{"href": "/static/assets/images/favicon.png"}]
+FAVICONS = [{"href": "/static/assets/images/winfo-favicon.jpg"}]

Review Comment:
   ### Invalid Favicon Format <sub>![category 
Readability](https://img.shields.io/badge/Readability-0284c7)</sub>
   
   <details>
     <summary>Tell me more</summary>
   
   ###### What is the issue?
   The favicon path is hardcoded to use a .jpg file, which is not a recommended 
format for favicons.
   
   
   ###### Why this matters
   JPG files don't support transparency and aren't optimized for favicon usage. 
This could result in poor quality favicons, especially when scaled.
   
   ###### Suggested change ∙ *Feature Preview*
   Change the favicon to use a more appropriate format like .ico or .png:
   ```python
   FAVICONS = [{"href": "/static/assets/images/winfo-favicon.png"}]
   ```
   
   
   ###### Provide feedback to improve future suggestions
   [![Nice 
Catch](https://img.shields.io/badge/👍%20Nice%20Catch-71BC78)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/9a3ab180-44a5-4107-b9fc-99f0989907aa/upvote)
 
[![Incorrect](https://img.shields.io/badge/👎%20Incorrect-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/9a3ab180-44a5-4107-b9fc-99f0989907aa?what_not_true=true)
  [![Not in 
Scope](https://img.shields.io/badge/👎%20Out%20of%20PR%20scope-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/9a3ab180-44a5-4107-b9fc-99f0989907aa?what_out_of_scope=true)
 [![Not in coding 
standard](https://img.shields.io/badge/👎%20Not%20in%20our%20standards-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/9a3ab180-44a5-4107-b9fc-99f0989907aa?what_not_in_standard=true)
 
[![Other](https://img.shields.io/badge/👎%20Other-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/9a3ab180-44a5-4107-b9fc-99f0989907aa)
   </details>
   
   <sub>
   
   💬 Looking for more details? Reply to this comment to chat with Korbit.
   </sub>
   
   <!--- korbi internal id:d3d317f2-813b-4c1c-9b2e-4f917c3e3f1f -->
   
   
   [](d3d317f2-813b-4c1c-9b2e-4f917c3e3f1f)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to