Re: [PR] build(dev-deps): update `fetch-mock` to v11 [superset]

Sun, 22 Jun 2025 02:53:51 -0700 


korbit-ai[bot] commented on code in PR #33854:
URL: https://github.com/apache/superset/pull/33854#discussion_r2160284143


##########
superset-frontend/jest.config.js:
##########
@@ -32,7 +32,7 @@ module.exports = {
       '<rootDir>/node_modules/@superset-ui/$1/src/$2',
     '^@superset-ui/([^/]+)$': '<rootDir>/node_modules/@superset-ui/$1/src',
   },
-  testEnvironment: 'jsdom',
+  testEnvironment: '<rootDir>/spec/helpers/jsDomWithFetchAPI.ts',

Review Comment:
   ### Missing explanation for custom test environment <sub>![category 
Documentation](https://img.shields.io/badge/Documentation-7c3aed)</sub>
   
   <details>
     <summary>Tell me more</summary>
   
   ###### What is the issue?
   The custom test environment file requires documentation about its purpose 
and differences from the standard 'jsdom' environment it replaces.
   
   
   ###### Why this matters
   Without understanding why a custom test environment is used, developers may 
revert to the standard jsdom environment, potentially breaking tests that rely 
on fetch API functionality.
   
   ###### Suggested change ∙ *Feature Preview*
   // Custom test environment that extends jsdom with fetch API support
   testEnvironment: '<rootDir>/spec/helpers/jsDomWithFetchAPI.ts',
   
   
   ###### Provide feedback to improve future suggestions
   [![Nice 
Catch](https://img.shields.io/badge/👍%20Nice%20Catch-71BC78)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/d7e51330-f69c-4fdf-880f-770f640b8353/upvote)
 
[![Incorrect](https://img.shields.io/badge/👎%20Incorrect-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/d7e51330-f69c-4fdf-880f-770f640b8353?what_not_true=true)
  [![Not in 
Scope](https://img.shields.io/badge/👎%20Out%20of%20PR%20scope-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/d7e51330-f69c-4fdf-880f-770f640b8353?what_out_of_scope=true)
 [![Not in coding 
standard](https://img.shields.io/badge/👎%20Not%20in%20our%20standards-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/d7e51330-f69c-4fdf-880f-770f640b8353?what_not_in_standard=true)
 
[![Other](https://img.shields.io/badge/👎%20Other-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/d7e51330-f69c-4fdf-880f-770f640b8353)
   </details>
   
   <sub>
   
   💬 Looking for more details? Reply to this comment to chat with Korbit.
   </sub>
   
   <!--- korbi internal id:b18b9426-32c9-42cd-af5a-bb85a597ad71 -->
   
   
   [](b18b9426-32c9-42cd-af5a-bb85a597ad71)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to