Re: [PR] style(menu): Reduce bottom border width of menu item [superset]

Fri, 20 Jun 2025 14:45:46 -0700 


korbit-ai[bot] commented on code in PR #33850:
URL: https://github.com/apache/superset/pull/33850#discussion_r2159696553


##########
superset-frontend/packages/superset-ui-core/src/components/Menu/index.tsx:
##########
@@ -99,7 +99,7 @@ const StyledNav = styled(AntdMenu)`
       ::after {
         content: '';
         position: absolute;
-        width: 100%;
+        width: 98%;

Review Comment:
   ### Unexplained Magic Number in CSS <sub>![category 
Readability](https://img.shields.io/badge/Readability-0284c7)</sub>
   
   <details>
     <summary>Tell me more</summary>
   
   ###### What is the issue?
   The width is specified as a magic number (98%) without explanation for why 
this specific value was chosen.
   
   
   ###### Why this matters
   Future developers may be unsure why 98% was selected over 100% or another 
value, making maintenance more difficult.
   
   ###### Suggested change ∙ *Feature Preview*
   Create a semantic CSS variable or theme constant like 
`--menu-item-border-width: 98%;` or add a comment explaining the significance 
of 98%.
   
   
   ###### Provide feedback to improve future suggestions
   [![Nice 
Catch](https://img.shields.io/badge/👍%20Nice%20Catch-71BC78)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/599e65f1-a74f-466b-ab4e-2bb6e570d3e3/upvote)
 
[![Incorrect](https://img.shields.io/badge/👎%20Incorrect-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/599e65f1-a74f-466b-ab4e-2bb6e570d3e3?what_not_true=true)
  [![Not in 
Scope](https://img.shields.io/badge/👎%20Out%20of%20PR%20scope-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/599e65f1-a74f-466b-ab4e-2bb6e570d3e3?what_out_of_scope=true)
 [![Not in coding 
standard](https://img.shields.io/badge/👎%20Not%20in%20our%20standards-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/599e65f1-a74f-466b-ab4e-2bb6e570d3e3?what_not_in_standard=true)
 
[![Other](https://img.shields.io/badge/👎%20Other-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/599e65f1-a74f-466b-ab4e-2bb6e570d3e3)
   </details>
   
   <sub>
   
   💬 Looking for more details? Reply to this comment to chat with Korbit.
   </sub>
   
   <!--- korbi internal id:53f9cc7d-8127-43f6-aaff-0c7fdf02ca64 -->
   
   
   [](53f9cc7d-8127-43f6-aaff-0c7fdf02ca64)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to