Re: [PR] chore: use mysql dialect for Pinot [superset]

Fri, 20 Jun 2025 11:34:38 -0700 


korbit-ai[bot] commented on code in PR #33848:
URL: https://github.com/apache/superset/pull/33848#discussion_r2159499110


##########
superset/sql/parse.py:
##########
@@ -85,7 +85,7 @@
     # "odelasticsearch": ???
     "oracle": Dialects.ORACLE,
     "parseable": Dialects.POSTGRES,
-    # "pinot": ???
+    "pinot": Dialect.MYSQL,

Review Comment:
   ### Incorrect MySQL Dialect Reference <sub>![category 
Functionality](https://img.shields.io/badge/Functionality-0284c7)</sub>
   
   <details>
     <summary>Tell me more</summary>
   
   ###### What is the issue?
   The code references `Dialect.MYSQL` but it should be `Dialects.MYSQL`.
   
   
   ###### Why this matters
   This will cause a runtime error since sqlglot uses `Dialects.MYSQL` instead 
of `Dialect.MYSQL`. The parser will fail to properly process Pinot SQL queries.
   
   ###### Suggested change ∙ *Feature Preview*
   Change `Dialect.MYSQL` to `Dialects.MYSQL`:
   ```python
   "pinot": Dialects.MYSQL,
   ```
   
   
   ###### Provide feedback to improve future suggestions
   [![Nice 
Catch](https://img.shields.io/badge/👍%20Nice%20Catch-71BC78)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/6355d86c-8a72-4493-9cd7-68abf3d31044/upvote)
 
[![Incorrect](https://img.shields.io/badge/👎%20Incorrect-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/6355d86c-8a72-4493-9cd7-68abf3d31044?what_not_true=true)
  [![Not in 
Scope](https://img.shields.io/badge/👎%20Out%20of%20PR%20scope-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/6355d86c-8a72-4493-9cd7-68abf3d31044?what_out_of_scope=true)
 [![Not in coding 
standard](https://img.shields.io/badge/👎%20Not%20in%20our%20standards-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/6355d86c-8a72-4493-9cd7-68abf3d31044?what_not_in_standard=true)
 
[![Other](https://img.shields.io/badge/👎%20Other-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/6355d86c-8a72-4493-9cd7-68abf3d31044)
   </details>
   
   <sub>
   
   💬 Looking for more details? Reply to this comment to chat with Korbit.
   </sub>
   
   <!--- korbi internal id:ab17ada4-b942-4cf4-8a78-7bd7c7d3fc50 -->
   
   
   [](ab17ada4-b942-4cf4-8a78-7bd7c7d3fc50)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to