gabotorresruiz opened a new pull request, #33808: URL: https://github.com/apache/superset/pull/33808
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> This PR adds a confirmation modal to alert users about unsaved changes in both the Dashboard Editing and Explore section. ### AFTER <!--- Skip this if not applicable --> #### Unsaved Changes on Dashboard Editing [unsaved_dashboard.webm](https://github.com/user-attachments/assets/03cad343-fa93-44da-9d53-d5ed1ce0ddf1) #### Unsaved Changes on Explore Section [unsaved_explore_section.webm](https://github.com/user-attachments/assets/bd7332f9-4b94-4f6c-bfee-dc52585bfc99) ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> 1. Dashboard Creation/Editing: - Navigate to an existing Dashboard or create a new one - Make any change without saving (e.g., add a chart) - Attempt to navigate away to a different section (e.g., Datasets) ✅ Expected behavior: A confirmation modal should appear prompting you to either Save or Discard your unsaved changes. 2. Explore Section: - Go to the Explore section - Without needing to make any change, try navigating away to another section (e.g., Datasets) ✅ Expected Behavior: A confirmation modal should appear asking you to `Save` or `Discard` your changes - If `Save` is selected, the standard save flow should execute ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
