geido commented on code in PR #33781:
URL: https://github.com/apache/superset/pull/33781#discussion_r2151932857
##########
superset-frontend/src/dashboard/components/SliceHeader/index.tsx:
##########
@@ -176,6 +183,17 @@ const SliceHeader = forwardRef<HTMLDivElement,
SliceHeaderProps>(
({ dashboardInfo }) => dashboardInfo.crossFiltersEnabled,
);
+ const chart = useSelector<RootState, Chart>(
+ state => state.charts[slice.slice_id],
+ );
+
+ const theme = useTheme();
+
+ const firstQueryResponse = chart.queriesResponse?.[0];
+
+ const rowLimit = Number(formData.row_limit || 0);
+ const sqlRowCount = Number(firstQueryResponse?.sql_rowcount || 0);
Review Comment:
Is falling back to 0 safe here? If no row limit is set and there are no
results from the query, wouldn't this show the warning incorrectly?
##########
superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx:
##########
@@ -527,6 +527,9 @@ const SliceHeaderControls = (
id={`slice_${slice.slice_id}-controls`}
aria-label="More Options"
aria-haspopup="true"
+ css={theme => css`
+ padding: ${theme.gridUnit * 1.5}px;
Review Comment:
Nit: Can we avoid the 1.5 here? Maybe 2 or just gridUnit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
