mistercrunch commented on code in PR #31646: URL: https://github.com/apache/superset/pull/31646#discussion_r2150786547
########## superset-frontend/src/dashboard/customTrads.ts: ########## @@ -0,0 +1,28 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { t } from '@superset-ui/core'; Review Comment: I'm thinking the goal here is to work around the issue I mentioned in a previous comment where `t()` only works for static strings. This seems hard to find, and wondering what's a better way to make sure all translatable strings are properly referenced, and sometimes augmented locally (?) Also noting the filename `customTrads` and thinking there's a translation issue in naming, where the french word `traduaction` usually maps to `translation` in english. All references to translation should use that term in english. Though I'm not sure whether we need/want this file here (?) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
