hainenber commented on code in PR #33637:
URL: https://github.com/apache/superset/pull/33637#discussion_r2148130953
##########
superset-frontend/packages/generator-superset/generators/plugin-chart/templates/package.erb:
##########
@@ -28,17 +28,23 @@
},
"dependencies": {},
"peerDependencies": {
- "@airbnb/config-babel": "^2.0.1",
"@superset-ui/chart-controls": "*",
"@superset-ui/core": "*",
- "react": "^17.0.2"
+ "antd-v5": "npm:antd@^5.18.0",
Review Comment:
thanks Maxime, I wasn't up-to-date on plugin scaffolder development. For
now, I think this PR is eligible for closing due to it building on something
redundant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
