rusackas commented on code in PR #32887:
URL: https://github.com/apache/superset/pull/32887#discussion_r2121671462
##########
docs/docs/configuration/databases.mdx:
##########
@@ -72,7 +72,7 @@ are compatible with Superset.
| [PostgreSQL](/docs/configuration/databases#postgres) |
`pip install psycopg2`
| `postgresql://<UserName>:<DBPassword>@<Database Host>/<Database Name>`
|
| [Presto](/docs/configuration/databases#presto) |
`pip install pyhive`
| `presto://{username}:{password}@{hostname}:{port}/{database}`
|
| [Rockset](/docs/configuration/databases#rockset) |
`pip install rockset-sqlalchemy`
| `rockset://<api_key>:@<api_server>`
|
-| [SAP Hana](/docs/configuration/databases#hana) |
`pip install hdbcli sqlalchemy-hana` or `pip install apache_superset[hana]`
| `hana://{username}:{password}@{host}:{port}`
|
+| [SingleStore](/docs/configuration/databases#singlestore) |
`pip install sqlalchemy-singlestoredb`
| `singlestoredb://{username}:{password}@{host}:{port}/{database}`
|
Review Comment:
Assuming we don't want to delete SAP Hana, but rather just _add_ SingleStore.
```suggestion
| [SAP Hana](/docs/configuration/databases#hana) | `pip install hdbcli
sqlalchemy-hana` or `pip install apache_superset[hana]` |
`hana://{username}:{password}@{host}:{port}` |
| [SingleStore](/docs/configuration/databases#singlestore) |
`pip install sqlalchemy-singlestoredb`
| `singlestoredb://{username}:{password}@{host}:{port}/{database}`
|
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
