Re: [PR] chore: simplify query cleanup using dict.pop instead of suppressing exception [superset]

Mon, 02 Jun 2025 01:12:45 -0700 


korbit-ai[bot] commented on code in PR #33661:
URL: https://github.com/apache/superset/pull/33661#discussion_r2120380390


##########
superset/charts/data/api.py:
##########
@@ -397,8 +397,7 @@ def _process_data(query_data: Any) -> Any:
             queries = result["queries"]
             if security_manager.is_guest_user():
                 for query in queries:
-                    with contextlib.suppress(KeyError):
-                        del query["query"]
+                    query.pop("query", None)

Review Comment:
   ### Inefficient Iteration for Key Removal <sub>![category 
Performance](https://img.shields.io/badge/Performance-4f46e5)</sub>
   
   <details>
     <summary>Tell me more</summary>
   
   ###### What is the issue?
   The code iterates through all queries to remove the 'query' key one at a 
time, which is inefficient for large query sets.
   
   
   ###### Why this matters
   For large sets of queries, performing individual pop operations in a loop 
creates unnecessary iteration overhead that could be optimized.
   
   ###### Suggested change ∙ *Feature Preview*
   Consider using a list comprehension or map operation to transform the 
queries in a single pass. For example:
   
   ```python
   if security_manager.is_guest_user():
       queries = [{k: v for k, v in q.items() if k != 'query'} for q in queries]
   ```
   
   
   ###### Provide feedback to improve future suggestions
   [![Nice 
Catch](https://img.shields.io/badge/👍%20Nice%20Catch-71BC78)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/dda49ccd-ab51-4317-904d-52918befe452/upvote)
 
[![Incorrect](https://img.shields.io/badge/👎%20Incorrect-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/dda49ccd-ab51-4317-904d-52918befe452?what_not_true=true)
  [![Not in 
Scope](https://img.shields.io/badge/👎%20Out%20of%20PR%20scope-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/dda49ccd-ab51-4317-904d-52918befe452?what_out_of_scope=true)
 [![Not in coding 
standard](https://img.shields.io/badge/👎%20Not%20in%20our%20standards-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/dda49ccd-ab51-4317-904d-52918befe452?what_not_in_standard=true)
 
[![Other](https://img.shields.io/badge/👎%20Other-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/dda49ccd-ab51-4317-904d-52918befe452)
   </details>
   
   <sub>
   
   💬 Looking for more details? Reply to this comment to chat with Korbit.
   </sub>
   
   <!--- korbi internal id:34fee76c-bbfb-4271-a98c-3fa6e6e7ee7e -->
   
   
   [](34fee76c-bbfb-4271-a98c-3fa6e6e7ee7e)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to