mistercrunch commented on code in PR #32556:
URL: https://github.com/apache/superset/pull/32556#discussion_r2118406295
##########
superset/daos/database.py:
##########
@@ -166,6 +170,44 @@ def get_ssh_tunnel(cls, database_id: int) -> SSHTunnel |
None:
return ssh_tunnel
+ @classmethod
+ def is_odps_partitioned_table(
Review Comment:
all of the database-engine-specific code belongs in this package ->
https://github.com/apache/superset/tree/master/superset/db_engine_specs
I see you you're setting this up as part of your PR, but this odps-specific
method/logic belongs in that module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
