betodealmeida commented on code in PR #33568:
URL: https://github.com/apache/superset/pull/33568#discussion_r2115912161
##########
superset/sql/dialects/firebolt.py:
##########
@@ -109,42 +109,15 @@ def _parse_unnest(self, with_alias: bool = True) ->
exp.Unnest | None:
expressions = self._parse_wrapped_csv(self._parse_expression)
offset = self._match_pair(TokenType.WITH, TokenType.ORDINALITY)
- alias = self._parse_table_alias() if with_alias else None
-
- if alias:
- if self.dialect.UNNEST_COLUMN_ONLY:
- if alias.args.get("columns"):
- self.raise_error("Unexpected extra column alias in
unnest.")
-
- alias.set("columns", [alias.this])
- alias.set("this", None)
-
- columns = alias.args.get("columns") or []
- if offset and len(expressions) < len(columns):
- offset = columns.pop()
-
- if not offset and self._match_pair(TokenType.WITH,
TokenType.OFFSET):
- self._match(TokenType.ALIAS)
- offset = self._parse_id_var(
- any_token=False, tokens=self.UNNEST_OFFSET_ALIAS_TOKENS
- ) or exp.to_identifier("offset")
-
return self.expression(
exp.Unnest,
expressions=expressions,
- alias=alias,
offset=offset,
)
class Generator(Firebolt.Generator):
def join_sql(self, expression: exp.Join) -> str:
- if not self.SEMI_ANTI_JOIN_WITH_SIDE and expression.kind in (
- "SEMI",
- "ANTI",
- ):
- side = None
- else:
- side = expression.side
Review Comment:
No `SEMI`/`ANTI` joins either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
