rea725 commented on code in PR #33146:
URL: https://github.com/apache/superset/pull/33146#discussion_r2114157052
##########
superset-frontend/plugins/plugin-chart-echarts/src/Waterfall/buildQuery.ts:
##########
@@ -28,6 +28,25 @@ export default function buildQuery(formData: QueryFormData) {
...ensureIsArray(x_axis || granularity_sqla),
...ensureIsArray(groupby),
];
+
+ if (columns.indexOf(formData.seriesOrderByColumn) === -1) {
Review Comment:
@michael-s-molina This is a feature, albeit one that merits caution and an
explanation. The reason for this is that we need to have the ability to
prescribe the order based on a sort order that is different than an
alphanumeric sort that is affected by the dimension used in the x-axis.
For example. I have a waterfall below that bridges from Gross Revenue to
Enterprise Profit.
It's important that the order is as follows:
Gross Revenue
Net Revenue
Gross Profit
Pre-Hurdle Profit
Enterprise Profit
We create this sort by sorting on Tier Sort v2, an engineered field that is
designed to produce the result we need.
If we don't do this, we get the original behavior of the waterfall chart,
which is to order the groupings as follows:
Enterprise Profit
Gross Profit
Net Revenue
Pre-Hurdle Profit
This creates an unacceptable result for this particular use case, and
without the ability to mandate sort order by a different column, we are forced
to rename our grouping entities with numeric prefixes or something (highly
undesirable) in order to get something approximating correct behavior.
Perhaps we need a helper tip in the configure screen to provide instructions
/ context for the sort feature?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
