mistercrunch opened a new pull request, #33593: URL: https://github.com/apache/superset/pull/33593
We've been talking about factoring out the reusable primitives from `src/components` to `packages/superset-ui-core/src/components` for a moment now. Followed most of what was stated here https://github.com/apache/superset/issues/33441 This might not be the final destination of where components will land. Final resting place of components might change to `/primitives` and/or outside of `core/`, but this surgery is the first big step in that direction. Work here include: * figuring out which components depend on the main app and should be collocated * de-tangling components that should NOT depend on the main app but did * sorted out imports, moving the proper imports to the right place, using peerDeps in the main package where packages are needed in both core/ and main app * mostly unified linting rules across the packages * [unfinished] flattening the components namespace, and generally bring all components and their types to a single namespace * bubbling up the module tree using export * as much as possible * improving typescript type specifications in many places * specifying exports in @superset-ui/core as opposed to using @superset-ui/core/src - unclear if I should move forward with this as it broke jest's mocking assumption, unclear if I push through or rollback this approach TODO: - fix jest tests, module resolution and mocks are broken RN and need attention - guessing cypress e2e tests need attention -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
