msyavuz commented on code in PR #33559:
URL: https://github.com/apache/superset/pull/33559#discussion_r2107719482
##########
superset-frontend/plugins/plugin-chart-echarts/src/Radar/transformProps.ts:
##########
@@ -259,6 +330,39 @@ export default function transformProps(
},
];
+ const NormalisedTooltipFormater = (
+ params: CallbackDataParams & {
+ color: string;
+ name: string;
+ value: number[];
+ },
+ ) => {
+ const { color } = params;
+ const seriesName = params.name || '';
+ const values = params.value;
+
+ const colorDot = `<span
style="display:inline-block;margin-right:5px;border-radius:50%;width:5px;height:5px;background-color:${color}"></span>`;
Review Comment:
Echarts expects a string and renderToStaticMarkup causes a performance hit.
See https://github.com/apache/superset/pull/33501. We should probably revert
this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
