Re: [PR] feat(pivot-table-chart) -> download as pivoted excel [superset]

Thu, 22 May 2025 21:45:18 -0700 


korbit-ai[bot] commented on code in PR #33569:
URL: https://github.com/apache/superset/pull/33569#discussion_r2103794172


##########
superset-frontend/src/dashboard/components/gridComponents/Chart.jsx:
##########
@@ -58,6 +58,8 @@ import {
 } from '../../util/activeDashboardFilters';
 import getFormDataWithExtraFilters from 
'../../util/charts/getFormDataWithExtraFilters';
 import { PLACEHOLDER_DATASOURCE } from '../../constants';
+import * as XLSX from 'xlsx';

Review Comment:
   ### Unused XLSX Import <sub>![category 
Readability](https://img.shields.io/badge/Readability-0284c7)</sub>
   
   <details>
     <summary>Tell me more</summary>
   
   ###### What is the issue?
   The XLSX library is imported but never used in the code, while the component 
relies on the `exportPivotExcel` utility for Excel-related operations.
   
   
   ###### Why this matters
   Unused imports increase bundle size and can lead to confusion about which 
Excel-related functionality is actually being used in the component.
   
   ###### Suggested change ∙ *Feature Preview*
   Remove the unused import:
   ```jsx
   // Remove this line
   // import * as XLSX from 'xlsx';
   ```
   
   
   ###### Provide feedback to improve future suggestions
   [![Nice 
Catch](https://img.shields.io/badge/👍%20Nice%20Catch-71BC78)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/70828018-1ece-405d-9e2b-f84390c938d7/upvote)
 
[![Incorrect](https://img.shields.io/badge/👎%20Incorrect-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/70828018-1ece-405d-9e2b-f84390c938d7?what_not_true=true)
  [![Not in 
Scope](https://img.shields.io/badge/👎%20Out%20of%20PR%20scope-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/70828018-1ece-405d-9e2b-f84390c938d7?what_out_of_scope=true)
 [![Not in coding 
standard](https://img.shields.io/badge/👎%20Not%20in%20our%20standards-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/70828018-1ece-405d-9e2b-f84390c938d7?what_not_in_standard=true)
 
[![Other](https://img.shields.io/badge/👎%20Other-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/70828018-1ece-405d-9e2b-f84390c938d7)
   </details>
   
   <sub>
   
   💬 Looking for more details? Reply to this comment to chat with Korbit.
   </sub>
   
   <!--- korbi internal id:dd19d2ad-48f3-4a56-815f-70d151b13212 -->
   
   
   [](dd19d2ad-48f3-4a56-815f-70d151b13212)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to