Vitor-Avila commented on code in PR #33553:
URL: https://github.com/apache/superset/pull/33553#discussion_r2103183519
##########
superset-frontend/src/features/allEntities/AllEntitiesTable.tsx:
##########
@@ -134,21 +136,37 @@ export default function AllEntitiesTable({
<AllEntitiesTableContainer>
{showListViewObjs ? (
<>
- <div className="entity-title">{t('Dashboards')}</div>
- {renderTable('dashboard')}
- <div className="entity-title">{t('Charts')}</div>
- {renderTable('chart')}
- <div className="entity-title">{t('Queries')}</div>
- {renderTable('query')}
+ {showDashboardList && (
+ <>
+ <div className="entity-title">{t('Dashboards')}</div>
+ {renderTable('dashboard')}
+ </>
+ )}
+ {showChartList && (
+ <>
+ <div className="entity-title">{t('Charts')}</div>
+ {renderTable('chart')}
+ </>
+ )}
+ {showQueryList && (
+ <>
+ <div className="entity-title">{t('Queries')}</div>
+ {renderTable('query')}
+ </>
+ )}
</>
) : (
- <EmptyState
- image="dashboard.svg"
- size="large"
- title={t('No entities have this tag currently assigned')}
- buttonAction={() => setShowTagModal(true)}
- buttonText={t('Add tag to entities')}
- />
+ <>
Review Comment:
great catch! Going to remove it. thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
