michael-s-molina commented on code in PR #33517:
URL: https://github.com/apache/superset/pull/33517#discussion_r2103032376
##########
superset-frontend/packages/superset-ui-core/src/chart/types/VizType.ts:
##########
@@ -54,6 +54,7 @@ export enum VizType {
Step = 'echarts_timeseries_step',
Sunburst = 'sunburst_v2',
Table = 'table',
+ TableAgGrid = 'table_ag_grid',
Review Comment:
It seems this component is well-written and doesn't have access to
Superset's internal state directly like Redux calls. There's currently an
effort from Preset to move many components from `src/components` to
`@superset-ui/core` to be reusable by plugins and later by extensions. This
seems like a perfect example of a valuable component that needs to be in
`@superset-ui/core`. In case, there are any references to Redux or Superset's
specific things, we just need to extract them from the component to a HOC and
keep the component as a UI element before moving to `@superset-ui/core`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
