betodealmeida commented on code in PR #33473:
URL: https://github.com/apache/superset/pull/33473#discussion_r2093300060
##########
superset/sql/parse.py:
##########
@@ -412,34 +427,12 @@ def format(self, comments: bool = True) -> str:
"""
Pretty-format the SQL statement.
"""
- if self._dialect:
- try:
- write = Dialect.get_or_raise(self._dialect)
- return write.generate(
- self._parsed,
- copy=False,
- comments=comments,
- pretty=True,
- )
- except ValueError:
- pass
-
- return self._fallback_formatting()
-
- @deprecated(deprecated_in="4.0")
Review Comment:
This was supposed to be removed in 5.0 and we missed the window, but it
doesn't break anything other than not being able to make queries pretty when
they don't have a `sqlglot` dialect.
We **need** to remove this in order to modify the `sqlglot` AST inplace.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
