amaannawab923 commented on code in PR #33357:
URL: https://github.com/apache/superset/pull/33357#discussion_r2081816081
##########
superset-frontend/plugins/plugin-chart-table/src/DataTable/components/GlobalFilter.tsx:
##########
@@ -66,17 +92,37 @@ export default (memo as <T>(fn: T) => T)(function
GlobalFilter<
200,
);
+ // Preserve focus during server-side filtering to maintain a better user
experience
+ useEffect(() => {
+ if (
+ serverPagination &&
+ isSearchFocused.get(id) &&
+ document.activeElement !== inputRef.current
+ ) {
+ inputRef.current?.focus();
+ }
+ }, [value, serverPagination]);
+
+ const handleChange = (e: React.ChangeEvent<HTMLInputElement>) => {
+ const target = e.target as HTMLInputElement;
+ e.preventDefault();
+ isSearchFocused.set(id, true);
+ setValue(target.value);
+ };
+
+ const handleBlur = () => {
+ isSearchFocused.set(id, false);
+ };
Review Comment:
Updating the map to inform that the field has lost focus ... and there is no
need to focus it on initial render
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
