Vitor-Avila opened a new pull request, #33384:
URL: https://github.com/apache/superset/pull/33384
### SUMMARY
The `catalog` value was not being included in the payload built by the
dataset edit modal during updates. This PR includes it when the associated DB
connection supports `multi_catalog`. If `multi_catalog` is disabled, then the
`dataset.catalog` value is likely the old one (as the modal wouldn't have a
catalog dropdown) and therefore is not included -- the backend will enforce the
proper default value.
This PR also fixes a couple of other things:
* The `validate` logic was relying on `self._properties.get("database")`,
but the schema actually expects `database_id`.
* The `validate` logic was always using `self._model.database`, even if the
update was re-mapping the dataset to a new DB connection. This would impact the
`catalog` assignment, uniqueness validation, etc.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
No UI changes.
### TESTING INSTRUCTIONS
Added unit and integration tests.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
