amaannawab923 commented on code in PR #33357:
URL: https://github.com/apache/superset/pull/33357#discussion_r2075850969
##########
superset/models/helpers.py:
##########
@@ -1888,12 +1888,26 @@ def get_sqla_query( # pylint:
disable=too-many-arguments,too-many-locals,too-ma
elif op in {
utils.FilterOperator.ILIKE.value,
utils.FilterOperator.LIKE.value,
+ utils.FilterOperator.TEXT_SEARCH.value,
}:
if target_generic_type != GenericDataType.STRING:
sqla_col = sa.cast(sqla_col, sa.String)
if op == utils.FilterOperator.LIKE.value:
where_clause_and.append(sqla_col.like(eq))
+ elif op == utils.FilterOperator.TEXT_SEARCH.value:
+ # Convert to string and handle None case
+ search_value = str(eq) if eq is not None else ""
+ if (
+ search_value
+ ): # Only add clause if search value is not empty
+ pattern = search_value.lower()
+ where_clause_and.append(
+ sa.or_(
+ sqla_col.ilike(f"{pattern}%"),
+ sqla_col.ilike(f"% {pattern}%"),
Review Comment:
@betodealmeida i agree , that we should maintain consistency from a ux
point of view but filtering results on every possible substring of the search
value absolutely breaks the table in case of analytics tables & gives random
results..
Here i am searching for all real_name that includes ad
<img width="1138" alt="Screenshot 2025-05-06 at 9 53 25 PM"
src="https://github.com/user-attachments/assets/8d2f1f79-a7ba-41af-92d5-da3f8c17aaed";
/>
& the search operation begins to feel random since Searches are supposed to
be based on prefixes
An example would be linkedin search below since it has the search by name
case
<img width="564" alt="Screenshot 2025-05-06 at 10 34 05 PM"
src="https://github.com/user-attachments/assets/ed43fc2c-e742-4b88-9c52-fa3e948d4b8c";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
