michael-s-molina commented on PR #33341: URL: https://github.com/apache/superset/pull/33341#issuecomment-2847057372
@justinpark The `View in SQL Lab` button is a great addition! About the "Format SQL" feature, I think a formatted SQL is better for users when visualizing a query. Given that https://github.com/apache/superset/pull/30350 states: > When running a query we pass it through sqlglot to prettify the SQL, but sqlglot is doing some unwanted changes when the dialect is set to generic. and the fact that the dialect will not be generic most of the time, I wonder if we should always format the SQL when visualizing the query. To be clear, I'm not proposing reverting @betodealmeida's changes but to always format the SQL when clicking on `View query`. If the dialect is generic, then you could always show the non-formatted version of the query and warning saying that the SQL can't be formatted for that database type. Pinging @betodealmeida, who probably has more context, to review too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
