fardin-developer commented on code in PR #33099:
URL: https://github.com/apache/superset/pull/33099#discussion_r2056314309
##########
superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberPeriodOverPeriod/utils.ts:
##########
@@ -40,20 +49,28 @@ const getFontSizeMapping = (
return acc;
}, {});
+const metricNameFontSizesMapping = getFontSizeMapping(
+ metricNameProportionValues,
+ sharedFontSizes,
+);
const headerFontSizesMapping = getFontSizeMapping(
headerProportionValues,
headerFontSizes,
);
const comparisonFontSizesMapping = getFontSizeMapping(
subheaderProportionValues,
- comparisonFontSizes,
+ sharedFontSizes,
);
+export const getMetricNameFontSize = (proportionValue: number) =>
+ metricNameFontSizesMapping[proportionValue] ??
+ sharedFontSizes[sharedFontSizes.length - 1];
Review Comment:
Yes, the logic is correct as implemented. It only defaults to the larger
font size when proportionValue isn’t found in the mapping—which should be rare
with controlled inputs. This fallback approach is consistent with the previous
logic used in getHeaderFontSize, maintaining the same design principle of
reliability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
