Re: [PR] Potential fix for code scanning alert no. 2001: DOM text reinterpreted as HTML [superset]

Tue, 22 Apr 2025 15:12:55 -0700 


korbit-ai[bot] commented on code in PR #33213:
URL: https://github.com/apache/superset/pull/33213#discussion_r2054961271


##########
superset-frontend/src/features/home/RightMenu.tsx:
##########
@@ -327,7 +327,7 @@ const RightMenu = ({
     ) : (
       <Menu.Item key={item.name} css={styledChildMenu}>
         {item.url ? (
-          <a href={ensureAppRoot(item.url)}> {item.label} </a>
+          <a href={sanitizeAndEnsureAppRoot(item.url)}> {item.label} </a>

Review Comment:
   ### Missing function import <sub>![category 
Functionality](https://img.shields.io/badge/Functionality-0284c7)</sub>
   
   <details>
     <summary>Tell me more</summary>
   
   ###### What is the issue?
   The code is using 'sanitizeAndEnsureAppRoot' function which is not imported 
or defined in the file.
   
   ###### Why this matters
   This will cause a runtime error as the function is undefined, breaking the 
menu functionality when users try to click on menu items with URLs.
   
   ###### Suggested change ∙ *Feature Preview*
   Import the sanitizeAndEnsureAppRoot function at the top of the file with 
other imports:
   
   ```typescript
   import { ensureAppRoot, sanitizeAndEnsureAppRoot } from 
'src/utils/pathUtils';
   ```
   
   
   ###### Provide feedback to improve future suggestions
   [![Nice 
Catch](https://img.shields.io/badge/👍%20Nice%20Catch-71BC78)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/bed46cb1-aacd-45e4-a22d-135acdac610c/upvote)
 
[![Incorrect](https://img.shields.io/badge/👎%20Incorrect-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/bed46cb1-aacd-45e4-a22d-135acdac610c?what_not_true=true)
  [![Not in 
Scope](https://img.shields.io/badge/👎%20Out%20of%20PR%20scope-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/bed46cb1-aacd-45e4-a22d-135acdac610c?what_out_of_scope=true)
 [![Not in coding 
standard](https://img.shields.io/badge/👎%20Not%20in%20our%20standards-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/bed46cb1-aacd-45e4-a22d-135acdac610c?what_not_in_standard=true)
 
[![Other](https://img.shields.io/badge/👎%20Other-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/bed46cb1-aacd-45e4-a22d-135acdac610c)
   </details>
   
   <sub>
   
   💬 Looking for more details? Reply to this comment to chat with Korbit.
   </sub>
   
   <!--- korbi internal id:83635226-0248-403f-a05f-a09662ac453a -->
   
   
   [](83635226-0248-403f-a05f-a09662ac453a)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to