payose opened a new pull request, #33170: URL: https://github.com/apache/superset/pull/33170
SUMMARY This PR reintroduces the slider as an additional method for configuring numerical range filters, based on community feedback following its removal in [#31726](https://github.com/apache/superset/pull/31726). **The main improvements include:** - [ ] Allowing users to select between Slider, Range Inputs, or both when configuring a numerical range filter. - [ ] Supporting cases where only one of the min or max values is configured, removing the previous dependency on both values. - [ ] Enhancing usability for large ranges by making the slider available. - [ ] Improving user guidance with placeholder defaults and metadata: - [ ] Placeholders display the dataset’s min and max values. - [ ] Metadata text like "Choose numbers between [x] and [x]" shown under the filter bar and in tooltips. - [ ] Handling synchronization between slider and inputs: Updating inputs dynamically when the slider changes, and vice versa. - [ ] UI behavior differs based on orientation: Horizontal mode: Slider rendered first, then inputs inline. Vertical mode: Metadata and error states positioned appropriately. - [ ] Updated error messages to include the actual valid ranges. - [ ] Ensured compatibility with the existing "Single value" filter configuration. BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF         TESTING INSTRUCTIONS Open a dashboard and add or edit a numerical range filter. In filter settings, configure: - Only slider enabled. - Only range inputs enabled. - Both slider and range inputs enabled. In vertical orientation: - Confirm metadata text appears correctly. - Confirm error states are shown under the filter with correct ranges. In horizontal orientation: - Confirm slider is shown first, inputs next to it. - Error is displayed via tooltip - Tooltip turns red to indicate when an error occurs Test synchronization: - Verify placeholders in inputs show dataset default min/max. - Move the slider and verify input values update accordingly. - Change input values and verify slider updates accordingly. - Leave min or max empty intentionally and verify filter works with just one value. - Validate that "Single value" mode continues working without issues. ADDITIONAL INFORMATION Has associated issue: [#33150](https://github.com/apache/superset/issues/33150) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
