EnxDev commented on code in PR #32905:
URL: https://github.com/apache/superset/pull/32905#discussion_r2039294586
##########
superset-frontend/src/components/Alert/Alert.stories.tsx:
##########
@@ -30,7 +30,7 @@ const bigText =
'purus convallis placerat in at nunc. Nulla nec viverra augue.';
export default {
- title: 'Alert',
+ title: 'Components/Alert',
Review Comment:
> I think it looks better this way too. But if we start doing this it should
be standardized as well. cc @geido
For now, I don't think there's a clear convention. Previously, some
components were inside the components folder and others outside, without really
following a specific structure/convention. So I decided to stick with the same
organization that already exists in the codebase for now.
@rusackas maybe we could align on a common structure together with the rest
of the community?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]