mistercrunch commented on code in PR #33024:
URL: https://github.com/apache/superset/pull/33024#discussion_r2031979768
##########
superset-frontend/src/SqlLab/components/QueryAutoRefresh/index.tsx:
##########
@@ -97,6 +112,17 @@ function QueryAutoRefresh({
{},
) ?? {};
dispatch(refreshQueries(queries));
+ jsonPayload.result.forEach(query => {
Review Comment:
ok with disregarding @korbit-ai's comment given it's probably rare that we
have multiple queries in a failed state, can probably afford the multi-rerender
in those rare cases.
##########
superset-frontend/src/SqlLab/components/QueryAutoRefresh/QueryAutoRefresh.test.tsx:
##########
@@ -34,6 +36,22 @@ import { QueryDictionary } from 'src/SqlLab/types';
const middlewares = [thunk];
const mockStore = configureStore(middlewares);
+const mockState = {
Review Comment:
NOTE: could be good to put in a reusable fixture file if there's a good
place for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
