ethan-l-geotab commented on issue #33044: URL: https://github.com/apache/superset/issues/33044#issuecomment-2794672712
Thanks for the feedback. 1. Should overhauling the existing publishing/draft system be in the scope of this sip? It seems to have a large scope, but I'm totally for it. Seems like the right way to do it to be honest, but I wasn't so sure such a big update would be approved without a big headache. 2. I think that modifying the status would be a good place to start. I'm open to other suggestions, not married to this idea, just what I had coded out at the moment. Theres no way of seeing both archived along with the other states at the same time the way it's done right now. <img width="291" alt="Image" src="https://github.com/user-attachments/assets/8898a219-e046-496f-8b6b-9b510a223188"; /> 3. I think that alerts/reports and stuff that are attached to archived dashboards should NOT be modified. Don't want to inadvertently break someone else's workflow i guess? 4. I think archiving and deleting although share a similar purpose are distinct and soft deleting is something that might be better addressed in the future? 5. Regarding the Published/Draft status for charts. Would be easier starting off with the triple status vs refactoring everything to work with the triple status. I didn't make a SIP for it quite just yet, but if we want archiving for it I think perhaps that PR can just be closed and work on it can be done with it under this SIP. Or I create a new one SIP regarding Draft/Publish/Archive for charts if that's preferable. https://github.com/apache/superset/pull/32969 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
