geido commented on PR #32705: URL: https://github.com/apache/superset/pull/32705#issuecomment-2787222746
> > I think at this point we can consider including it for all the components. > > As I mentioned [here](https://github.com/apache/superset/pull/32705#issuecomment-2765931501), these components will be moved later to an NPM package and consumers will probably import them like: > > ``` > import { Skeleton } from '@superset-ui/components'; > ``` > > so it will be easier to migrate later if their current import is: > > ``` > import { Skeleton } from 'src/components'; > ``` > > This also aligns with how we import Ant Design and `@superset/core` components. @michael-s-molina it is in our plans to move all components inside ui-core as part of the theming effort and prior to that to change all of the imports to use `src/components. It is true that some got changed in the wrong direction in this PR but we were aware of it and accepted it as part of the feature branch. I am personally going to open a PR to fix all of these and all others in the codebase soon. Thanks for catching this! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
