125m125 commented on PR #32891: URL: https://github.com/apache/superset/pull/32891#issuecomment-2770565148
@sfirke Thank you for the feedback, I have capitalized Superset and implemented the error-handling suggestion. I have done it in two commits in case you prefer the error handling to be a separate PR, since it isn't only documentation anymore. I only tested the change manually. I don't know if it is possible to add automatic test for the changes, since the exception should only occur when the statsd-package is missing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
