michael-s-molina commented on code in PR #29422:
URL: https://github.com/apache/superset/pull/29422#discussion_r2026791141


##########
superset-frontend/src/dashboard/components/DashboardBuilder/state.ts:
##########
@@ -29,6 +29,9 @@ import {
 // eslint-disable-next-line import/prefer-default-export
 export const useNativeFilters = () => {
   const [isInitialized, setIsInitialized] = useState(false);
+  const showNativeFilters = useSelector<RootState, boolean>(
+    state => getUrlParam(URL_PARAMS.showFilters) ?? true,

Review Comment:
   @Vitor-Avila The [original 
code](https://github.com/apache/superset/pull/23228/files#diff-6f2c6562ff1fad0ce405b3507cddff63a25dc91c76fb8613284b9cbb241dd928)
 had `&& state.dashboardInfo.metadata?.show_native_filters`. Isn't that needed 
anymore?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to